On Mon, Aug 29, 2011 at 11:28:42AM +0530, ABRAHAM, KISHON VIJAY wrote:
> > -#ifdef VERBOSE_DEBUG
> > -# define ehci_vdbg ehci_dbg
> > -#else
> > - static inline void ehci_vdbg(struct ehci_hcd *ehci, ...) {}
> > -#endif
> > -
> > -#ifdef DEBUG
> > -
> > /* check the values in the HCSPARAMS register
> > * (host controller _Structural_ parameters)
> > * see EHCI spec, Table 2-4 for each value
> > */
> > -static void dbg_hcs_params (struct ehci_hcd *ehci, char *label)
>
> This patch should be split further. All these generic part where you
> modify ehci-dbg.c, ehci-lpm.c, ehci-q.c, ehci-sched.c should be done
> prior to this patch and compiling ehci-pci as a separate unit should
> only be taken care in this patch.
This could be done. If we take the usb_hcd_add_init() thingy then we could
avoid exporting large parts of the hc_driver struct and only grab the struct
and pass reset as an argument. So only the debug stuff has to be exported
then.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
