Re: [PATCH 06/20] usb: hcd-pci: introduce pm-ops for platform-pci devs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/23/2011 07:14 PM, Felipe Balbi wrote:
You don't seem to understand that I am proposing a way to do just that:
decouple PCI from the host stack.  It's just that I'm proposing a
_different_ way from what Sebastian posted.

I think we agree on the first few patches. Where we don't agree is that
we split the PCI device into two parts: one which understands PCI and
the second which does xhci only.

I didn't see a proposal yet. In fact, all you said was this might not be
a good approach. So, if you _do_ have a better approach, please show it
to us. But to me splitting the IP into its own platform_device has

Another approach that comes to mind would be (looking from my tree where this series is applied)
- take what is in xhci_probe() with following arguments:irq, memory and
  reset callback
- everyone who wants a XHCI device (pci or platform device) would use
  this function and provide the information.
- ->self.controller would be still struct device which is part of
   struct pci_dev. However the xhci is not allowed to touch this since
   it may be part of platform_device so only the xhci-pci may touch it.
   This should not be a problem pm and msi-x would need a callback for
   that.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux