Re: [PATCH 2/2] USB: Gadget: Add Audio Class 2.0 Driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Aug 22, 2011 at 05:28:05PM +0300, Felipe Balbi wrote:
> > >> Otherwise, please have a look at audio.c and audio2.c and suggest what
> > >> exactly you mean.
> > >
> > > audio.c doesn't do anything audio related. It's just adding the
> > > configuration to composite layer. The real specification is implemented
> > > in f_audio.c (should probably be called f_uac1.c, though).
> > Agreed. Reusing audio.c is quite reasonable.
> > So, I'll :-
> > * Merge audio2.c into audio.c
> > * Rename f_audio.c -> f_uac1.c

just another tip/request:

when generating your patches add -M -C switches to git format-patch.
This will let git detect the renaming.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux