RE: [PATCH] USB: EHCI: remove usages of hcd->state

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 19 Aug 2011, JinGoo Han wrote:

> Hi, Alan.
> > -----Original Message-----
> > From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb-
> > owner@xxxxxxxxxxxxxxx] On Behalf Of Alan Stern
> > Sent: Friday, August 19, 2011 5:32 AM
> > To: Greg KH
> > Cc: USB list
> > Subject: [PATCH] USB: EHCI: remove usages of hcd->state
> > 
> > This patch (as1483) improves the ehci-hcd driver family by getting rid
> > of the reliance on the hcd->state variable.  It has no clear owner and
> > it isn't protected by the usual HCD locks.  In its place, the patch
> > adds a new, private ehci->rh_state field to record the state of the
> > root hub.
> > 
> > Along the way, the patch removes a couple of lines containing
> > redundant assignments to the state variable.  Also, the QUIESCING
> > state simply gets changed to the RUNNING state, because the driver
> > doesn't make any distinction between them.
> > 
> > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> 
> Acked-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> 
> I reviewed your patch and tested ehci-s5p.c.
> It works properly.

Great!  Thanks for testing.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux