Re: [PATCH] usb gadget: fix null pointer dereference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Yang Rui Rui | 2011-08-17 17:25:59 [+0800]:

>Following patch also fix my problem, anyone can explain a bit about the comment?
>Where to set the CONFIG_USB_GADGET_DUALSPEED?

This is selected by the driver which supports. Which driver are you
using, is it out of tree?

>In my case musb gadget set is_dualspeed to 1, but gadget_is_dualspeed return 0,
>so hs_descriptors is not copied.
Hmm. USB_GADGET_MUSB_HDRC selects USB_GADGET_DUALSPEED so it should
return 1.

>diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
>index 087f4b9..d9b5bdb 100644
>--- a/include/linux/usb/gadget.h
>+++ b/include/linux/usb/gadget.h
>@@ -548,14 +548,7 @@ static inline struct usb_gadget *dev_to_usb_gadget(struct device *dev)
>  */
> static inline int gadget_is_dualspeed(struct usb_gadget *g)
> {
>-#ifdef CONFIG_USB_GADGET_DUALSPEED
>-   /* runtime test would check "g->is_dualspeed" ... that might be
>-    * useful to work around hardware bugs, but is mostly pointless
>-    */
>-   return 1;
>-#else
>-   return 0;
>-#endif
>+ return g->is_dualspeed;
> }
> /**

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux