Re: [PATCH] usb: musb: move to threaded IRQ

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 12, 2011 at 03:25:49PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 12-08-2011 13:38, Felipe Balbi wrote:
> 
> >this allows us to stop exporting the musb_interrupt
> >handler while also following the main idea of having
> >threaded IRQs: top half should only check if interrupt
> >comes from this device.
> 
> >Signed-off-by: Felipe Balbi<balbi@xxxxxx>
> >---
> >  drivers/usb/musb/am35x.c     |    2 +-
> >  drivers/usb/musb/musb_core.c |   14 ++++++++++----
> >  drivers/usb/musb/musb_core.h |    2 --
> >  3 files changed, 11 insertions(+), 7 deletions(-)
> 
> >diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/musb/am35x.c
> >index 08f1d0b6..3080400 100644
> >--- a/drivers/usb/musb/am35x.c
> >+++ b/drivers/usb/musb/am35x.c
> >@@ -310,7 +310,7 @@ static irqreturn_t am35x_musb_interrupt(int irq, void *hci)
> >  	}
> >
> >  	if (musb->int_tx || musb->int_rx || musb->int_usb)
> >-		ret |= musb_interrupt(musb);
> >+		ret = IRQ_WAKE_THREAD;
> >
> >  eoi:
> >  	/* EOI needs to be written for the IRQ to be re-asserted. */
> 
>    I thought musb_interrupt() is also referenced in blackfin.c,
> da8xx.c, davinci.c and tusb6010.c...

hmm... true... I was too fast when doing this patch. Will try to fix
that part too thanks for notifying me ;-)

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux