Hi, On Tue, Aug 02, 2011 at 05:22:50PM +0200, Sebastian Andrzej Siewior wrote: > Greg was fine getting rid of the include hell and use modules or some > other tricks to avoid redundancy. This patch collects the files > composite.c usbstring.c config.c epautoconf.c and creates the > usb-composite.ko instead of including the files directly. I don't know > yet what to do about [uf]_* so I will worry about them later. > > Here are some stats (x86_64, gcc-4.6): > > text data bss dec diff filename > new | old new | old new | old new | old > > 7130 18018 590 710 56 152 7776 18880 -11104 audio.o > 19792 30668 672 792 240 312 20704 31772 -11068 cdc2.o > 7542 8690 124 124 144 148 7810 8962 -1152 dbgp.o > 25479 36387 1040 1164 156 248 26675 37799 -11124 ether.o > 25181 27192 534 534 112 116 25827 27842 -2015 file_storage.o > 33646 44636 1116 1240 92 216 34854 46092 -11238 g_ffs.o > 7615 9633 392 392 112 116 8119 10141 -2022 gmidi.o > 5035 15913 408 508 64 184 5507 16605 -11098 hid.o > 11222 11222 244 244 16 16 11482 11482 0 inode.o > 21722 32616 516 640 308 376 22546 33632 -11086 mass_storage.o > 53064 64039 1512 1632 528 600 55104 66271 -11167 multi.o > 13905 24759 639 759 92 184 14636 25702 -11066 ncm.o > 25246 36186 1190 1310 144 248 26580 37744 -11164 nokia.o > 10682 12686 1481 1481 306 312 12469 14479 -2010 printer.o > 13508 24420 686 806 208 280 14402 25506 -11104 serial.o > 9982 20935 405 525 4 88 10391 21548 -11157 webcam.o > 6127 17045 588 716 112 184 6827 17945 -11118 zero.o > > 11315 100 92 11507 usb-composite.o > > So for all users we have: > Total new: 311709 > Total old: 452402 > > The diff is ~137KiB where the usb-composite module is only ~11KiB. > For drivers using the composite it makes hardly a difference. With the > second gadget driver we start saving space. For those that don't use the > composite framework or use just a few functions, they use more size due > to the module. > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> please, resend without RFC. Nobody complained about it in over a week. -- balbi
Attachment:
signature.asc
Description: Digital signature
