Hi, On Fri, Aug 05, 2011 at 10:36:03AM +0200, Sebastian Andrzej Siewior wrote: > Oliver Neukum wrote: > >Am Donnerstag, 4. August 2011, 21:33:31 schrieb Sebastian Andrzej Siewior: > >>use status variable instead of explicit gotos to distinguish between a > >>repsonse and stall condition. > > > >Why? Where's the improvement? You have even reduced the information > >content to the reader. "goto stall" is very clear. "status = -EOPNOTSUPP" is > >meaningless. > > How so? composite_setup() and other gadgets return a this (a negative > error code) to let udc driver know to reply with a stall. The stall label > itself returned earlier the same error code for the same purpose. The goto > statements are nice for clean-ups and so on but this criss-cross jumps can > be handler in a nicer way. any more comments here ? This thread simply died. -- balbi
Attachment:
signature.asc
Description: Digital signature
