Re: [RFC PATCH 1/2] usb: Add physical layer utility code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 05, 2011 at 05:13:58PM +0300, Heikki Krogerus wrote:
> Hi,
> 
> On Fri, Aug 05, 2011 at 02:42:56PM +0200, Sascha Hauer wrote:
> > Yes, that's clear to me. I just wondered what exact names we should use
> > to register a phy.
> > 
> > Consider a phy registering itself with
> > 
> > 	usb_register_transceiver(recv) with recv->name = "mxc-ehci.0"
> > 
> > (where recv->name could be passed from platform_data)
> > 
> > Then the mxc-ehci driver could get its receiver using
> > 
> > 	usb_get_transceiver(dev_name(&pdev->dev))
> > 
> > or with
> > 
> > 	usb_get_transceiver(&pdev->dev);
> > 
> > when we do what I suggested. This would be similar to the clocks which
> > get the clocks associated to a device with clk_get(&pdev->dev, id).
> > 
> > This would change the behaviour of usb_get_transceiver() from "give me
> > the phy with this name" to "give me the transceiver associated with this
> > device". It would prevent us from inventing arbitrary phy names.
I agree with you. Just add related controller's name at transceiver's pdata,
Then the reader can know this phy is used at this controller at this board.

> 
> OK, I understand now. We need to think about this. It could be worth
> doing. I need to make a new version of these, so I can try something
> like that.
> 
> Thanks,
> 
> -- 
> heikki
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 

Best Regards,
Peter Chen

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux