On Thu, Jul 28, 2011 at 12:10:05PM +0100, Andrew Bird (Sphere Systems) wrote: > Hi Sergei, > > On Thursday 28 July 2011, Sergei Shtylyov wrote: > > Hello. > > > > On 27-07-2011 20:03, Andrew Bird wrote: > > > This patch adds the product ID of Huawei's Vodafone K3770 mobile > > > broadband modem to option.c. This is necessary so that the driver gets > > > loaded on demand without the intervention of usb_modeswitch. This has > > > the benefit of it becoming available faster and also ensures that the > > > option driver is not bound to a network interface that should be claimed > > > by cdc_ether. > > > > You seem to be adding 4 product IDs with the identical patch > > descriptions. Why not do it in a single patch? > > > > > Signed-off-by: Andrew Bird <ajb@xxxxxxxxxxxxxxxxxxx> > > > > WBR, Sergei > > I'm pretty new to this, but I was following the one patch per change > idea, so as there are four devices I did a patch for each. > > Happy to squash into one if that's more acceptable to people? As you did it is fine, I'll queue it up next week when I return from vacation. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html