On Wed, Jul 27, 2011 at 08:24:14AM +0200, Oliver Neukum wrote:
> Am Mittwoch, 27. Juli 2011, 06:04:19 schrieb Greg Kroah-Hartman:
> > @@ -187,8 +187,8 @@ static struct xhci_ring *xhci_ring_alloc(struct xhci_hcd *xhci,
> >
> > if (link_trbs) {
> > /* See section 4.9.2.1 and 6.4.4.1 */
> > - prev->trbs[TRBS_PER_SEGMENT-1].link.
> > - control |= cpu_to_le32(LINK_TOGGLE);
> > + prev->trbs[TRBS_PER_SEGMENT-1].link.control |=
> > + cpu_to_le32(LINK_TOGGLE);
>
> Hi,
>
> I am not objecting to this particular piece of code. However calling
> this readable is a joke, before and after. So could someone please stop
> those people who make a religion out of the number of characters in a line?
I agree with you that it's not readable, and I would love to allow
longer lines in the xHCI code if it made things more readable.
My main issue is I run all my commits (and all the contributor commits
that I apply through git-am) through checkpatch.pl with a git hook. And
it will stop a rebase of those commits if it finds a style issue
(because even a style warning causes the script to return an error code,
which git rebase will then assume something has gone horribly wrong).
I can always turn it completely off, but then I miss other blatant style
issues. I submitted a patch to checkpatch to change the return code of
checkpatch.pl to return success if there was only warnings, but I heard
crickets after the initial griping about "why do you need this?"
Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
