Re: [PATCH 5/7] ehci mxc: make it more flexible to be used for mx28

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Jul 20, 2011 at 07:08:24PM +0800, Tony Lin wrote:
> @@ -165,14 +187,15 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev)
>  	}
>  
>  	/* enable clocks */
> -	priv->usbclk = clk_get(dev, "usb");
> -	if (IS_ERR(priv->usbclk)) {
> -		ret = PTR_ERR(priv->usbclk);
> -		goto err_clk;
> +	if (!cpu_is_mx28()) {

this should not be used in drivers, IMHO.

> +		priv->usbclk = clk_get(dev, "usb");

drivers should not have to care about clock names, are you sure your
clkdev support is correct ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux