On Tue, 19 Jul 2011, Tanmay Upadhyay wrote:
> On Tuesday 19 July 2011 03:17 PM, Tanmay Upadhyay wrote:
> >
> >
> > On Monday 18 July 2011 12:22 PM, Tanmay Upadhyay wrote:
> >> - Add EHCI Host controller driver
> >> - Add wrapper that creates resources for host controller driver
> >>
> >> Signed-off-by: Tanmay Upadhyay<tanmay.upadhyay@xxxxxxxxxxxxxx>
...
> >> --- /dev/null
> >> +++ b/drivers/usb/host/ehci-pxa168.c
> >> +static int __devinit ehci_pxa168_drv_probe(struct platform_device
> >> *pdev)
> >> +{
...
> >> + /* Enable USB clock */
> >> + drv_data->pxa168_usb_clk = clk_get(&pdev->dev, "PXA168-USBCLK");
> >> + if (IS_ERR(drv_data->pxa168_usb_clk)) {
> >> + dev_err(&pdev->dev, "Couldn't get USB clock\n");
> >> + err = PTR_ERR(drv_data->pxa168_usb_clk);
> >> + goto err4;
> >> + }
> >> + clk_enable(drv_data->pxa168_usb_clk);
> >> +
> >> + err = pxa168_usb_phy_init(pdev);
> >> + if (err) {
> >> + dev_err(&pdev->dev, "USB PHY initialization failed\n");
> >> + goto err5;
> >> + }
...
> >> +err5:
> >> + clk_disable(drv_data->pxa168_usb_clk);
Shouldn't there be a clk_put() here?
> >> +err4:
...
> > It was sad to know that David Brownell is no more with us. Added new
> > maintainer for EHCI - Alan Stern in loop.
> Alan,
>
> You may refer the whole thread at
> http://lists.arm.linux.org.uk/lurker/message/20110718.065208.bbec3843.en.html
Thank you. Apart from this one problem,
Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
