Hi Balbi, 2011/07/09 7:09, Felipe Balbi wrote: > Hi, > > On Thu, Jul 07, 2011 at 09:58:00AM +0900, Yoshihiro Shimoda wrote: >> @@ -215,18 +230,12 @@ static inline void r8a66597_write_fifo(struct r8a66597 *r8a66597, >> adj = 0x01; /* 16-bit wide */ >> } >> >> + if (r8a66597->pdata->wr0_shorted_to_wr1) > > you never defined wr0_shorted_to_wr1. Thanks, Greg, for noticing it. I > dropped this patch now. > Possibly I should have written some comments... I submitted a patch for r8a66597-hcd for USB host, and the patch adds the definition. I confirmed that the host side patch was already merged to usb-next branch. (commit ID: f2e9039a43 "usb: r8a66597-hcd: add function for external controller") The include/linux/usb/r8a66597.h is used by both host and gadget. Should I resend a patch of r8a66597-udc using current usb-next branch? Best regards, Yoshihiro Shimoda -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html