RE: [PATCH 05/41] usb: gadget: use config_ep_by_speed() instead of ep_choose()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 29 Jun 2011, Tanya Brokhman wrote:

> 
> > -----Original Message-----
> > From: Greg KH [mailto:greg@xxxxxxxxx]
> > Sent: Tuesday, June 28, 2011 9:16 PM
> > To: Felipe Balbi
> > Cc: Linux USB Mailing List; Tatyana Brokhman
> > Subject: Re: [PATCH 05/41] usb: gadget: use config_ep_by_speed()
> > instead of ep_choose()
> > 
> > On Tue, Jun 28, 2011 at 04:33:50PM +0300, Felipe Balbi wrote:
> > > From: Tatyana Brokhman <tlinder@xxxxxxxxxxxxxx>
> > >
> > > Remove obsolete functions:
> > > 1. ep_choose()
> > > 2. usb_find_endpoint()
> > >
> > > Signed-off-by: Tatyana Brokhman <tlinder@xxxxxxxxxxxxxx>
> > > Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> > 
> > This patch causes the following warnings to be printed out, hopefully
> > they will go away in a later patch in this series...
> > 
> > drivers/usb/gadget/storage_common.c:498:1: warning: ‘fsg_ep_desc’
> > defined but not used
> 
> 
> It's defined in storage_common.c and is used by the file_storage gadget. That's why I didn't remove it, file_storage.c won't compile without it.
> I can add an #ifdef CONFIG_USB_FILE_STORAGE arounf the definition if you prefere....

Or add __maybe_unused.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux