Den 23. juni 2011 12:46, skrev Sergei Shtylyov:
Hello.
On 22-06-2011 19:26, Marius B. Kotsbak wrote:
-Support for big endian.
-Do not use USB buffers at the stack.
-Safer/more efficient code for local constants.
Signed-off-by: Marius B. Kotsbak<marius@xxxxxxxxxxx>
---
drivers/net/usb/kalmia.c | 40
++++++++++++++++++++++++----------------
1 files changed, 24 insertions(+), 16 deletions(-)
- char receive_buf[28];
+ const static int buflen = 28;
Why declare it at all, when it's used only once?
+ char *usb_buf;
int status;
- status = kalmia_send_init_packet(dev, init_msg_1,
sizeof(init_msg_1)
- / sizeof(init_msg_1[0]), receive_buf, 24);
+ usb_buf = kmalloc(buflen, GFP_DMA | GFP_KERNEL);
+ if (!usb_buf)
+ return -ENOMEM;
+
+ memcpy(usb_buf, init_msg_1, 12);
s/12/sizeof(init_msg_1)/
+ status = kalmia_send_init_packet(dev, usb_buf, sizeof(init_msg_1)
+ / sizeof(init_msg_1[0]), usb_buf, 24);
There's ARRAY_SIZE() macro to replace:
sizeof(init_msg_1) / sizeof(init_msg_1[0])
and why not use just sizeof(init_msg_1)?
if (status != 0)
return status;
- status = kalmia_send_init_packet(dev, init_msg_2,
sizeof(init_msg_2)
- / sizeof(init_msg_2[0]), receive_buf, 28);
+ memcpy(usb_buf, init_msg_2, 12);
s/12/sizeof(init_msg_2)/
+ status = kalmia_send_init_packet(dev, usb_buf, sizeof(init_msg_2)
+ / sizeof(init_msg_2[0]), usb_buf, 28);
The same comment here about:
sizeof(init_msg_2) / sizeof(init_msg_2[0])
Thanks for the tips. I know some parts of the code are a bit ugly, but
the primary goal was to get it working despite the quirky state of the
current modem firmware. I have noted it for later fixing.
--
Marius
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
