Hi, On Wed, Jun 22, 2011 at 04:20:49PM +0200, Sebastian Andrzej Siewior wrote: > >> diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c > >> index 2ddb7c8..08221fa 100644 > >> --- a/drivers/usb/gadget/udc-core.c > >> +++ b/drivers/usb/gadget/udc-core.c > >> @@ -164,6 +164,7 @@ int usb_add_gadget_udc(struct device *parent, struct usb_gadget *gadget) > >> device_initialize(&udc->dev); > >> udc->dev.release = usb_udc_release; > >> udc->dev.class = udc_class; > >> + udc->dev.groups = usb_udc_attr_groups; > >> udc->dev.parent = parent; > >> ret = dev_set_name(&udc->dev, "%s", kobject_name(&parent->kobj)); > >> if (ret) > >> @@ -468,8 +469,6 @@ static int __init usb_udc_init(void) > >> } > >> > >> udc_class->dev_uevent = usb_udc_uevent; > >> - udc_device_type.groups = usb_udc_attr_groups; > >> - > >> return 0; > >> } > >> subsys_initcall(usb_udc_init); > > > >I wonder if it would be simpler to just assign the device type > >correctly ? > > So instead dev.groups I assign dev.type. Not sure if this makes sense > unless we distinguish between 2.0 and 3.0 gadgets and have different > attributes and runtime pm callbacks. we probably won't do that any time soon. So I'll take your approach, unless someone else has problems with it... I'm planning to send a pull request to Greg this friday, then I'll be done for the merge window and everybody should start moving to bug fixing. -- balbi
Attachment:
signature.asc
Description: Digital signature
