* Felipe Balbi | 2011-06-22 16:26:18 [+0300]: >Hi, Hi, >> diff --git a/drivers/usb/gadget/udc-core.c b/drivers/usb/gadget/udc-core.c >> index 2ddb7c8..08221fa 100644 >> --- a/drivers/usb/gadget/udc-core.c >> +++ b/drivers/usb/gadget/udc-core.c >> @@ -164,6 +164,7 @@ int usb_add_gadget_udc(struct device *parent, struct usb_gadget *gadget) >> device_initialize(&udc->dev); >> udc->dev.release = usb_udc_release; >> udc->dev.class = udc_class; >> + udc->dev.groups = usb_udc_attr_groups; >> udc->dev.parent = parent; >> ret = dev_set_name(&udc->dev, "%s", kobject_name(&parent->kobj)); >> if (ret) >> @@ -468,8 +469,6 @@ static int __init usb_udc_init(void) >> } >> >> udc_class->dev_uevent = usb_udc_uevent; >> - udc_device_type.groups = usb_udc_attr_groups; >> - >> return 0; >> } >> subsys_initcall(usb_udc_init); > >I wonder if it would be simpler to just assign the device type >correctly ? So instead dev.groups I assign dev.type. Not sure if this makes sense unless we distinguish between 2.0 and 3.0 gadgets and have different attributes and runtime pm callbacks. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
