Hi,
On Fri, Jun 17, 2011 at 10:32:29AM -0400, Alan Stern wrote:
> On Fri, 17 Jun 2011, Sebastian Andrzej Siewior wrote:
>
> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> > ---
> > v1..v2:
> > * Alan Stern | 2011-06-16 16:33:44 [-0400]:
> >
> > >I meant you should do this:
> > >
> > >static int dummy_udc_suspend(struct platform_device *pdev, pm_message_t state)
> > >{
> > > dev_dbg(&pdev->dev, "%s\n", __func__);
> > > dummy_udc_pm(pdev, 1);
> > > usb_hcd_poll_rh_status(dummy_hcd_to_hcd(dum_hcd));
> > > return 0;
> > >}
> >
> > Now I'm adding more than I remove but atleast the common bits are in one
> > place.
>
> That's okay. You could improve the line count slightly by passing dum
> and dum_hcd as arguments to dummy_udc_pm() instead of pdev.
that's true, not sure dummy_udc_pm() needs to know about pdev...
--
balbi
Attachment:
signature.asc
Description: Digital signature
