Re: [PATCH v2 5/6] usb/dummy_hcd: move common bits of suspend/resume into one function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 17 Jun 2011, Sebastian Andrzej Siewior wrote:

> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> ---
> v1..v2:
> * Alan Stern | 2011-06-16 16:33:44 [-0400]:
> 
> >I meant you should do this:
> >
> >static int dummy_udc_suspend(struct platform_device *pdev, pm_message_t state)
> >{
> >	dev_dbg(&pdev->dev, "%s\n", __func__);
> >	dummy_udc_pm(pdev, 1);
> >	usb_hcd_poll_rh_status(dummy_hcd_to_hcd(dum_hcd));
> >	return 0;
> >}
> 
> Now I'm adding more than I remove but atleast the common bits are in one
> place.

That's okay.  You could improve the line count slightly by passing dum 
and dum_hcd as arguments to dummy_udc_pm() instead of pdev.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux