Re: [PATCH 2/3 v2] usb: renesas_usbhs: support multi-channels

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Magnus

Thank you for checking patch.

> > Â* Â Â Â Â Â Â linux usb function
> > Â*
> > Â*/
> > -struct usbhsg_gpriv *the_controller;
> > +#define THE_CONTROLLER_CNT 2 /* USB0 and USB1 */
> > +struct usbhsg_gpriv *the_controllers[THE_CONTROLLER_CNT];
> 
> Sorry, but this is just too ugly to be acceptable. I would prefer not
> to have these kind of global variables at all if possible, but I
> realize that's not up to you. I don't have any good suggestion to fix
> this on a global scale either, so I should probably just shut up.
> 
> Anyway, since we do seem to need global state, why don't you fix up
> the code to use a linked list implementation instead?

Thanks. Good idea !
I try to create v2 patch which use linked list.

Best regards
--
Kuninori Morimoto
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux