Re: [PATCH] usb: renesas_usbhs: care buff alignment when dma handler

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dear Greg

Today I sent 3 patches to ML.
      usb: renesas_usbhs: care buff alignment when dma handler
      usb: renesas_usbhs: inaccessible pipe is not an error
      usb: renesas_usbhs: support multi driver

But please drop these. I'm so sorry.
It was wrong/old "Signed-off-by" address.
I should modify it.
and some of these patch seems unstable on some board.
I modify and re-send it.

So sorry again.

> Signed-off-by: Kuninori Morimoto <morimoto.kuninori@xxxxxxxxxxx>
> ---
>  drivers/usb/renesas_usbhs/fifo.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c
> index 2016a24..0e66f7a 100644
> --- a/drivers/usb/renesas_usbhs/fifo.c
> +++ b/drivers/usb/renesas_usbhs/fifo.c
> @@ -633,6 +633,9 @@ static int usbhsf_dma_prepare_push(struct usbhs_pkt *pkt, int *is_done)
>  	if (len % 4) /* 32bit alignment */
>  		goto usbhsf_pio_prepare_push;
>  
> +	if (((u32)pkt->buf + pkt->actual) & 0x7) /* 8byte alignment */
> +		goto usbhsf_pio_prepare_push;
> +
>  	/* get enable DMA fifo */
>  	fifo = usbhsf_get_dma_fifo(priv, pkt);
>  	if (!fifo)
> @@ -708,6 +711,9 @@ static int usbhsf_dma_try_pop(struct usbhs_pkt *pkt, int *is_done)
>  	if (ret < 0)
>  		goto usbhsf_pio_prepare_pop;
>  
> +	if (((u32)pkt->buf + pkt->actual) & 0x7) /* 8byte alignment */
> +		goto usbhsf_pio_prepare_pop;
> +
>  	/* use PIO if packet is less than pio_dma_border */
>  	len = usbhsf_fifo_rcv_len(priv, fifo);
>  	len = min(pkt->length - pkt->actual, len);
> -- 
> 1.7.4.1
> 


EC No. 11-TR0006 # Linux BSP
EC No. W         # public

Best regards
--
Kuninori Morimoto
 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux