* Kukjin Kim | 2011-06-14 11:33:11 [+0900]:
>Hi Felipe and Sebastian,
Hi Kukjin,
>> ACKs ?
>>
>Hmm...
>
>In this case, proper platform_driver_unregister should be added if need to
>fix the error path.
>
>I think, since the S3C2410 H/W fifo_size of the EP[1~4] is different with
>S3C2440, we need to handle it now. Of course the USB 1.1 bulk max packet is
>64 bytes and according to current driver code handles just 64bytes fifo_size
>during write_packet not 128bytes fifo_size.
>
>So it seems we don't need to handle different fifo_size but if required, to
>add its handling looks better.
You need to difference between those two chips in your probe function
and I don't know how do you want to do this without ids. So what about I
add this to the patch:
enum s3c_udc_type {
S3C2410-USBGADGET,
S3C2440-USBGADGET,
};
static const struct platform_device_id s3c_udc_ids[] = {
{ "s3c2410-usbgadget", s3c2410-usbgadget},
{ "s3c2440-usbgadget", s3c2440-usbgadget},
};
MODULE_DEVICE_TABLE(platform, s3c_udc_ids);
and once you are going to add the different fifo sizes to the driver you
can use:
const struct platform_device_id *id = platform_get_device_id(dev);
enum s3c_udc_type udc_type = id->driver_data;
in the probe function. What do you think?
>Thanks.
>
>Best regards,
>Kgene.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
