Felipe Balbi wrote: > > On Thu, Jun 09, 2011 at 10:21:06PM +0200, Sebastian Andrzej Siewior wrote: > > This also fixes the error path: If the second device fails to register > > we never remove the first one. > > This is compile-tested only. I don't see any difference between those > > two. Maybe we should just use one name instead? > > > > Cc: Ben Dooks <ben-linux@xxxxxxxxx> > > Cc: Kukjin Kim <kgene.kim@xxxxxxxxxxx> > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx> > Hi Felipe and Sebastian, > ACKs ? > Hmm... In this case, proper platform_driver_unregister should be added if need to fix the error path. I think, since the S3C2410 H/W fifo_size of the EP[1~4] is different with S3C2440, we need to handle it now. Of course the USB 1.1 bulk max packet is 64 bytes and according to current driver code handles just 64bytes fifo_size during write_packet not 128bytes fifo_size. So it seems we don't need to handle different fifo_size but if required, to add its handling looks better. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@xxxxxxxxxxx>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
