On Thu, 9 Jun 2011, Tanya Brokhman wrote: > > > + if (!mod_data.is_high_speed && mod_data.is_super_speed) > > > + return -EINVAL; > > > > Print an error message in the log so that the user will know why the > > failure occurred. > > > > But when the module fails to load the message sais that it's invalid > parameter (or something like that). That's why I thought it will be enough. Oh yes, that's true. > You mean to add something that explains WHY these values are wrong? That's what I had in mind. But "invalid parameter" is probably good enough, since these are the _only_ parameters. :-) So this part is okay as it stands. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html