> > I thought about that as well. Even added it but removed at the last > minute > > :) I encountered quite a few places in the code where some error > message to > > the user is really needed but is missing > > What other places? There is very little the user has to do with > dummy-hcd -- really nothing more than setting the module parameters. I'm not talking about dummy_hcd. It was a general comment about the gadget code. I can't give you an example from the top of my head... > > so my impression was that it's best > > to keep the printks to a minimum. Isn't that the general approach? > IMO, in > > this particular case informing the user isn't a "must". If you feel > strongly > > about it I can add the message. > > IMO the driver should print an error message and fail to load if there > are contradictory module parameters. > Well, I can add the error message but I think that as far as dummy_hcd is concerned failing it's loading is a bit harsh, isn't it? I mean, this is a type of user error that can be fixed so why not fix it and just notify the user of what was done? Thanks, Tanya Brokhman --- Sent by an consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
