On Tue, 7 Jun 2011, Tanya Brokhman wrote: > > You might want to print out some kind of error message if the user > > specifies is_super_speed = True and is_high_speed = False. > > > > I thought about that as well. Even added it but removed at the last minute > :) I encountered quite a few places in the code where some error message to > the user is really needed but is missing What other places? There is very little the user has to do with dummy-hcd -- really nothing more than setting the module parameters. > so my impression was that it's best > to keep the printks to a minimum. Isn't that the general approach? IMO, in > this particular case informing the user isn't a "must". If you feel strongly > about it I can add the message. IMO the driver should print an error message and fail to load if there are contradictory module parameters. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
