Re: [RFC v4] introduce UDC class

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 06/03/11 19:07, Sebastian Andrzej Siewior wrote:
> This is the fourth edition of the udc-class 
> v1 -> v2:
>  - udc_lock is now a mutex
>  - send KOBJ_CHANGE with KOBJ_CHANGE=driver->function on
>    attaching/deatching gadget drivers.
>  - udc class is auto-selected if gadget support is enabled.
> v2 -> v3:
>  - exetended the critical section in usb_add_gadget_udc() and shorten in
>  - dropping the lock in a few error cases
>  - rebase ontop of v3.0-rc1
> v3 -> v4:
>  - dropped the function driver conversion. There no more bind callback.
>  - converted all udc drivers
> 
> Sebastian
Hi Sebastian,

Just a suggestion for the form of this RFC rather than a comment on
the actual work.  Could you add a third patch removing all of the stuff
that will no longer be necessary (even if it is marked as breaking unconverted
drivers).  That way everyone can see the benefit.  I initially read this
a series that removed duplicated operations, but in doing some substantially
increased the amount of code (which was odd!)

Jonathan

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux