Re: [PATCH] USB: s3c-hsotg: Tone down debugging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

Michal Nazarewicz wrote:

The style is to do:

#ifdef DEBUG

static void s3c_hsotg_dump(struct s3c_hsotg *hsotg)
{
    /* ... */
}

#else

static inline void s3c_hsotg_dump(struct s3c_hsotg *hsotg)
{}

That's only worthwhile if you also move the code around to allow the use
of the inline declaration.

My point was to put #ifdef outside of the function.  I thought it was in
CodingStyle but I cannot find it now

   Because it's in SubmittingPatches. ;-)

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux