Re: [PATCH] USB: s3c-hsotg: Tone down debugging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 01 Jun 2011 19:36:10 +0200, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:

On Wed, Jun 01, 2011 at 07:34:43PM +0200, Michal Nazarewicz wrote:

The style is to do:

#ifdef DEBUG

static void s3c_hsotg_dump(struct s3c_hsotg *hsotg)
{
	/* ... */
}

#else

static inline void s3c_hsotg_dump(struct s3c_hsotg *hsotg)
{}

That's only worthwhile if you also move the code around to allow the use
of the inline declaration.

My point was to put #ifdef outside of the function.  I thought it was in
CodingStyle but I cannot find it now -- so don't mind me and sorry about
the noise.  I must have had to little sleep tonight and feel too
coding-style-nazi.

--
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michal "mina86" Nazarewicz    (o o)
ooo +-----<email/xmpp: mnazarewicz@xxxxxxxxxx>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux