* Alan Stern | 2011-05-31 15:38:16 [-0400]: >> + int (*stop)(struct usb_gadget *, struct usb_gadget_driver *); >> }; > >Why does the stop method take a usb_gadget_driver argument? The only >place in this patch series where gadget->ops->stop() is called, the >second argument is always NULL. Is that a bug? It is a bug, indeed. I moved the ->unbind(), ->pulldown() execution out of the the udc driver. So I could remove second argument. I didn't and the pointer check was still there and dummy_hcd's ->stop() callback simply returned doing nothing. Lesson learned. The stop callback should only disable the HW and not doing anything else. This will be done in a later patch. For now I simply rename the functions and done remove code. >Alan Stern Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
