On Mon, 30 May 2011, Sebastian Andrzej Siewior wrote:
> From: Felipe Balbi <balbi@xxxxxx>
>
> these two methods will be used to tell
> controller driver to prepare for starting/stopping
> operation with a gadget driver. They will
> be implemented and used by the new usb udc
> class which will come in later patches.
>
> Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> ---
> include/linux/usb/gadget.h | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
> index dd1571d..bf945c5 100644
> --- a/include/linux/usb/gadget.h
> +++ b/include/linux/usb/gadget.h
> @@ -417,6 +417,7 @@ static inline void usb_ep_fifo_flush(struct usb_ep *ep)
> /*-------------------------------------------------------------------------*/
>
> struct usb_gadget;
> +struct usb_gadget_driver;
>
> /* the rest of the api to the controller hardware: device operations,
> * which don't involve endpoints (or i/o).
> @@ -430,6 +431,8 @@ struct usb_gadget_ops {
> int (*pullup) (struct usb_gadget *, int is_on);
> int (*ioctl)(struct usb_gadget *,
> unsigned code, unsigned long param);
> + int (*start)(struct usb_gadget *, struct usb_gadget_driver *);
> + int (*stop)(struct usb_gadget *, struct usb_gadget_driver *);
> };
Why does the stop method take a usb_gadget_driver argument? The only
place in this patch series where gadget->ops->stop() is called, the
second argument is always NULL. Is that a bug?
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
