Michal Nazarewicz wrote:
On Mon, 30 May 2011 19:28:35 +0200, Sebastian Andrzej Siewior
<bigeasy@xxxxxxxxxxxxx> wrote:
@@ -833,19 +840,9 @@ usb_gadget_unregister_driver (struct
usb_gadget_driver *driver)
set_link_state (dum);
spin_unlock_irqrestore (&dum->lock, flags);
- driver->unbind (&dum->gadget);
- dum->gadget.dev.driver = NULL;
- dum->driver = NULL;
-
- spin_lock_irqsave (&dum->lock, flags);
- dum->pullup = 0;
- set_link_state (dum);
- spin_unlock_irqrestore (&dum->lock, flags);
-
usb_hcd_poll_rh_status (dummy_to_hcd (dum));
return 0;
}
Why are we deleting all those lines?
All of this happens in usb_gadget_remove_driver(). The second block is
open-coded pullup callback.
After converting a few drivers it seems better do it in a later patch and
leave here and remove it later.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
