* Michal Nazarewicz | 2011-05-20 20:28:59 [+0200]:
mutex_lock_interruptible()? This applies to other places as well.
On Fri, 20 May 2011 12:02:59 +0200, Sebastian Andrzej Siewior wrote:
Why do we want to abort on signal?
* Michal Nazarewicz | 2011-05-23 18:54:50 [+0200]:
Why don't we want to do that? If something hands, user should be able
to interrupt operation with a signal, I don't see why she shouldn't.
On Wed, 25 May 2011 17:52:37 +0200, Sebastian Andrzej Siewior wrote:
It looks like duct tape. She should not run into dead locks.
So lets see: rmmod on a module, module try to lock udc_lock, we get a
signal, we fail with an error code, the module is removed (the driver
remains registered).
OK, haven't thought about it. Still, we should be fine using
mutex_lock_interruptible() in usb_add_gadget_udc() and
usb_gadget_register_driver(). Either way, at this point, I'm
not insisting.
Coding style requires the braces be dropped though.
http://lxr.linux.no/linux+*/Documentation/CodingStyle#L166
Since you insist, I'm going to change this.
If it were up to me I would require the braces, but the coding style
knows no mercy. ;)
--
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michal "mina86" Nazarewicz (o o)
ooo +-----<email/xmpp: mnazarewicz@xxxxxxxxxx>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
