Re: [patch 1/1] USB: yurex: recognize GeneralKeys wireless presenter as generic HID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 23, 2011 at 03:29:58PM -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> From: Tomoki Sekiyama <tomoki.sekiyama@xxxxxxxxx>
> 
> Unfortunately, the device seems to have the same Vendor ID and Product ID
> as YUREX leg-shakes sensors, and the commit 6bc235a2e2 ("USB: add driver
> for Meywa-Denki & Kayac YUREX") added the ID to hid_ignore_list.
> 
> I believe that we can distinguish YUREX and the Wireless Presenter by
> device type.  The patch below makes the driver ignore only YUREX
> (bInterfaceProtocol==0), and recognize Wireless Presenter
> (bInterfaceProtocol is keyboard or mouse) as generic HID.  (I don't have
> the Wireless Presenter, so not yet ested.)
> 
> ** YUREX lsusb information:
> Bus 002 Device 007: ID 0c45:1010 Microdia
> Device Descriptor:
>    bLength                18
>    bDescriptorType         1
>    bcdUSB               1.10
>    bDeviceClass            0 (Defined at Interface level)
>    bDeviceSubClass         0
>    bDeviceProtocol         0
>    bMaxPacketSize0         8
>    idVendor           0x0c45 Microdia
>    idProduct          0x1010
>    bcdDevice            0.03
>    iManufacturer           1 JESS
>    iProduct                2 YUREX
>    iSerial                 3 10000269
>    bNumConfigurations      1
>    Configuration Descriptor:
>      bLength                 9
>      bDescriptorType         2
>      wTotalLength           34
>      bNumInterfaces          1
>      bConfigurationValue     1
>      iConfiguration          0
>      bmAttributes         0xa0
>        (Bus Powered)
>        Remote Wakeup
>      MaxPower              100mA
>      Interface Descriptor:
>        bLength                 9
>        bDescriptorType         4
>        bInterfaceNumber        0
>        bAlternateSetting       0
>        bNumEndpoints           1
>        bInterfaceClass         3 Human Interface Device
>        bInterfaceSubClass      1 Boot Interface Subclass
>        bInterfaceProtocol      0 None
>        iInterface              0
>          HID Device Descriptor:
>            bLength                 9
>            bDescriptorType        33
>            bcdHID               1.10
>            bCountryCode            0 Not supported
>            bNumDescriptors         1
>            bDescriptorType        34 Report
>            wDescriptorLength      31
>           Report Descriptors:
>             ** UNAVAILABLE **
>        Endpoint Descriptor:
>          bLength                 7
>          bDescriptorType         5
>          bEndpointAddress     0x81  EP 1 IN
>          bmAttributes            3
>            Transfer Type            Interrupt
>            Synch Type               None
>            Usage Type               Data
>          wMaxPacketSize     0x0008  1x 8 bytes
>          bInterval              10
> Device Status:     0x0002
>    (Bus Powered)
>    Remote Wakeup Enabled
> 
> Addresses https://bugzilla.kernel.org/show_bug.cgi?id=26922
> 
> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@xxxxxxxxx>
> Cc: Greg KH <gregkh@xxxxxxx>
> Cc: "Rafael J. Wysocki" <rjw@xxxxxxx>
> Cc: Maciej Rutecki <maciej.rutecki@xxxxxxxxx>
> Reported-by: Thomas Bäler <thomas@xxxxxxxxxxxxx>
> Tested-by: Thomas Bäler <thomas@xxxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
>  drivers/hid/hid-core.c        |    6 +++++-
>  drivers/hid/usbhid/hid-core.c |    2 ++
>  include/linux/hid.h           |    3 ++-
>  3 files changed, 9 insertions(+), 2 deletions(-)

I think you need to adjust your patch scripts, this should go to Jiri
Kosina <jkosina@xxxxxxx>, the HID maintainer, not me.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux