Re: [PATCH] usb/gadget: use dummy_pullup() instead of open coding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Alan Stern | 2011-05-20 11:09:58 [-0400]:

>On Fri, 20 May 2011, Sebastian Andrzej Siewior wrote:
>
>> The only difference is that the first replacement in
>> usb_gadget_unregister_driver() now also calls usb_hcd_poll_rh_status().
>> It doesn't look like it causes any harm.
>
>This may be simply a matter of personal taste, but I don't like to read 
>patch descriptions that make no sense without reading the patch title 
>first.  It's as though somebody started a conversation by saying: "The 
>difference is that Linux is open." -- it makes me go "What?"

I try to add something into the body so it does not make you go "What?"
:)

>> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
>
>This patch is okay with me, 
Is this an Acked-by?

>but it is likely to conflict with the work 
>that Tatyana and Felipe are doing.  You might want to coordinate with 
>them first.

It clashes with Tatyana's SS-addon and with the udc-class. That is why I
want to get it out of the way asap.
I'm not aware that Felipe has something in the pipe.

Tanya, do you want this on-top of your patches or the other way around?
It works both ways for me.

>Alan Stern
>

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux