Re: [PATCH] usb/gadget: use dummy_pullup() instead of open coding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 20 May 2011, Sebastian Andrzej Siewior wrote:

> The only difference is that the first replacement in
> usb_gadget_unregister_driver() now also calls usb_hcd_poll_rh_status().
> It doesn't look like it causes any harm.

This may be simply a matter of personal taste, but I don't like to read 
patch descriptions that make no sense without reading the patch title 
first.  It's as though somebody started a conversation by saying: "The 
difference is that Linux is open." -- it makes me go "What?"

> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

This patch is okay with me, but it is likely to conflict with the work 
that Tatyana and Felipe are doing.  You might want to coordinate with 
them first.

Alan Stern



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux