On Fri, May 13, 2011 at 2:35 PM, Premi, Sanjeev <premi@xxxxxx> wrote: >> -----Original Message----- >> From: Munegowda, Keshava >> Sent: Friday, May 13, 2011 12:04 PM >> To: Igor Grinberg >> Cc: Premi, Sanjeev; linux-usb@xxxxxxxxxxxxxxx; >> linux-omap@xxxxxxxxxxxxxxx; Balbi, Felipe; Gadiyar, Anand; >> parthab@xxxxxxxxxxxx >> Subject: Re: [PATCH 3/5] arm: omap: usb: device name change >> for the clk names of usbhs >> >> On Thu, May 12, 2011 at 4:58 PM, Igor Grinberg >> <grinberg@xxxxxxxxxxxxxx> wrote: >> > >> > >> > On 05/12/11 13:49, Premi, Sanjeev wrote: >> > >> >>> -----Original Message----- >> >>> From: linux-omap-owner@xxxxxxxxxxxxxxx >> >>> [mailto:linux-omap-owner@xxxxxxxxxxxxxxx] On Behalf Of >> >>> Munegowda, Keshava >> >>> Sent: Wednesday, May 11, 2011 7:35 PM >> >>> To: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx >> >>> Cc: Munegowda, Keshava; Balbi, Felipe; Gadiyar, Anand; >> >>> parthab@xxxxxxxxxxxx >> >>> Subject: [PATCH 3/5] arm: omap: usb: device name change for >> >>> the clk names of usbhs >> >> [snip]...[snip] >> >> >> >>> --- a/drivers/mfd/omap-usb-host.c >> >>> +++ b/drivers/mfd/omap-usb-host.c >> >>> @@ -27,7 +27,7 @@ >> >>> #include <linux/gpio.h> >> >>> #include <plat/usb.h> >> >>> >> >>> -#define USBHS_DRIVER_NAME "usbhs-omap" >> >>> +#define USBHS_DRIVER_NAME "usbhs_omap" >> >>> #define OMAP_EHCI_DEVICE "ehci-omap" >> >>> #define OMAP_OHCI_DEVICE "ohci-omap3" >> >> >> >> [sp] Shouldn't we be consistent in using minus/dash and >> >> underscore in the device names? >> > >> > Also, can't we avoid once again changing the clock names >> > (at least for a while...)? >> > Is that really necessary? Can't hwmod use current clock names? >> > Because, Linus is sooo happy each time he sees that kind of >> changes.... >> > >> >> This was actually earlier comment saying use _ as the convention for >> hwmod and runtime pm. >> only usbhs_omap uses the hwmod; the ehci and ohci drivers are children >> of usbhsh and they get the >> data from usbhs. Hence the older name of ehci and ochi drivers are >> retained as it is. >> if it is really needed, to change ehci and ohci driver names , then >> i can make it as another patch. > > [sp] A common convetion helps. Another patch will definitely help usability. > > ~sanjeev sure, I will send ASAP. > >> >> >> > >> > -- >> > Regards, >> > Igor. >> > >> > >> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
