On Thu, 05 May 2011 12:36:34 +0530 Pavan Kondeti <pkondeti@xxxxxxxxxxxxxx> wrote: ... > > diff --git a/include/linux/usb/otg.h b/include/linux/usb/otg.h > > index 6e40718..bc84858 100644 > > --- a/include/linux/usb/otg.h > > +++ b/include/linux/usb/otg.h > > @@ -246,5 +246,6 @@ otg_unregister_notifier(struct otg_transceiver *otg, struct notifier_block *nb) > > > > /* for OTG controller drivers (and maybe other stuff) */ > > extern int usb_bus_start_enum(struct usb_bus *bus, unsigned port_num); > > +extern const char *otg_state_string(enum usb_otg_state state); > > > > #endif /* __LINUX_USB_OTG_H */ > > I think you should move otg_state_string() function to under #ifdef > CONFIG_USB_OTG_UTILS block and provide nop if it is not defined. > Otherwise compilation may fail if anyone includes linux/usb/otg.h > without defining CONFIG_USB_OTG_UTILS. Okay, since the original patch is already in the usb git tree and Greg asked for an incremental patch, I'll add a nop in an incremental patch for fixing musb drivers build. Thanks, Anatolij -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
