Re: [PATCH V4 2/5] USB: OTG: msm: vote for dayatona fabric clock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 03, 2011 at 05:59:37PM +0530, Pavan Kondeti wrote:
> Hi Sergei,
> 
> On 5/3/2011 4:44 PM, Sergei Shtylyov wrote:
> > Hello.
> > 
> > On 03-05-2011 9:13, Pavankumar Kondeti wrote:
> > 
> >> From: Anji jonnala <anjir@xxxxxxxxxxxxxx>
> > 
> >> HSUSB core clock is derived from daytona fabric clock and for
> >> HSUSB operational require minimum core clock at 55MHz. Since, HSUSB
> >> cannot tolerate daytona fabric clock change in the middle of HSUSB
> >> operational, vote for maximum Daytona fabric clock
> >> while usb is operational
> > 
> >> Signed-off-by: Anji jonnala<anjir@xxxxxxxxxxxxxx>
> >> Signed-off-by: Pavankumar Kondeti<pkondeti@xxxxxxxxxxxxxx>
> > [...]
> > 
> >> diff --git a/drivers/usb/otg/msm_otg.c b/drivers/usb/otg/msm_otg.c
> >> index 2965986..cfbb606 100644
> >> --- a/drivers/usb/otg/msm_otg.c
> >> +++ b/drivers/usb/otg/msm_otg.c
> > [...]
> >> @@ -954,7 +979,11 @@ free_regs:
> >>   put_core_clk:
> >>   	if (motg->core_clk)
> >>   		clk_put(motg->core_clk);
> >> -	clk_put(motg->pclk);
> > 
> >     Is it really correct to remove this line?
> > 
> No. It is not correct. I will fix it in next version.

Next version?

Ok, I'll drop all of these then from my queue.  Please resend when you
have something working properly.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux