Re: [PATCH 2/5] usb/isp1760: Remove false error printout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sebastian Andrzej Siewior wrote:
> Arvid Brodin wrote:
>> This removes the "qh is 0" printout. qh == NULL if the urb has
>> been unlinked, so this condition is normal.
> 
> If this is normal please add a comment where this happens. I tried to
> remove the URB from the hardware so it does complete after removal.

As far as I can see, what happens is that sometimes when unlinking
(dequeueing) an urb with an active ptd, the ptd finishes while
urb_dequeue() is executing within its spinlock, but before the ptd is
zeroed out. This sets the interrupt flag for the ptd, and when the
interrupt is later executed, priv->xxxints[x].qh for the ptd has been
set to NULL by urb_dequeue(). It happens rather frequently when running
the unlink tests in the usbtest suite.

> 
> Sebastian

-- 
Arvid Brodin
Enea Services Stockholm AB
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux