On Tue, Apr 26, 2011 at 2:04 AM, Felipe Balbi <balbi@xxxxxx> wrote: > On Tue, Apr 26, 2011 at 02:32:04PM +0530, Keshava Munegowda wrote: >> > -----Original Message----- >> > From: Felipe Balbi [mailto:balbi@xxxxxx] >> > Sent: Tuesday, April 26, 2011 2:29 PM >> > To: Keshava Munegowda >> > Cc: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; balbi@xxxxxx; >> gadiyar@xxxxxx; p- >> > basak2@xxxxxx; axel.lin@xxxxxxxxx; johnstul@xxxxxxxxxx; >> mpfj-list@xxxxxxxxxx >> > Subject: Re: [PATCH] mfd: Fix usbhs_enable error handling >> > >> > Hi, >> > >> > On Thu, Apr 21, 2011 at 07:52:41PM +0530, Keshava Munegowda wrote: >> > > From: Axel Lin <axel.lin@xxxxxxxxx> >> > > >> > > In the case of missing platform_data we do not hold a spin_lock, >> > > thus we should not call spin_unlock_irqrestore in the error path. >> > > >> > > Also simplify the error handling by separating the successful path >> > > from error path. I think this change improves readability. >> > > >> > > Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx> >> > >> > Can someone give me a Tested-by so I can take these patches. >> > >> > -- >> > Balbi >> >> Hi Balbi >> >> I have validated this patch and it works :) >> >> Tested-by: Keshava Munegowda <keshava_mgowda@xxxxxx> > > what about the others ? > > -- > balbi Hi Felipe, I responded on another thread. I tested this on a beagleboardxm on version 2.6.39-rc4 > Hi Keshava, > > I rebuilt my system to boot from flash and now I see what happened. I > even remember it being discussed on this list. Someone renamed my usb > ethernet device from usb0 to eth0 !!! The boot log shows it on this line: > > > [ 4.596130] smsc95xx 1-2.1:1.0: eth0: register 'smsc95xx' at > > usb-ehci-omap.0d > > > So this broke my init scripts and uboot script... OK, so I can live with > this (I hope the name doesn't change too often though). > > So I can manually configure my system to use eth0 and use the network. I > am sure I will get nfs working shortly. > > I am using the 2.6.39-rc4 with your 3 patches. So from the Beagleboard > XM perspective it works and you can include my > > Tested-by: Steve Calfee <stevecalfee@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
