On Fri, 22 Apr 2011, Sarah Sharp wrote: > Also, I think the port link state reporting for the USB 3.0 roothub has > a bug in it: > > > + /* Port Link State */ > > + if (hcd->speed == HCD_USB3) > > + status |= (temp & PORT_PLS_MASK); > > The link state is almost identical between the external USB 3.0 hub > fields and the xHCI fields, except that xHCI reports a "resume" state of > 0xF, and the USB 3.0 bus spec lists the 0xF value as reserved. So the > USB core wouldn't know what to make of the link state being set to > resume. I'm not sure what state we should report to the USB core when > the xHC sets the state to resume. Perhaps U0? The state machine in > figure 34 shows that's the next state after the Resume state. The port link state should be reported using the same value as an external hub would use under the same circumstances. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
