Re: [PATCH 1/2] USB: EHCI: Support controllers with big endian capability regs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 04/20/2011 04:57 PM, Alan Stern wrote:
> On Wed, 20 Apr 2011, Jan Andersson wrote:
> 
>> The two first HC capability registers (CAPLENGTH and HCIVERSION)
>> are defined as one 8-bit and one 16-bit register. Most HC
>> implementations have selected to treat these registers as part
>> of a 32-bit register, giving the same layout for both big and
>> small endian systems.
>>
>> This patch adds a new quirk, big_endian_capbase, to support
>> controllers with big endian register interfaces that treat
>> HCIVERSION and CAPLENGTH as individual registers.
>>
>> Signed-off-by: Jan Andersson <jan@xxxxxxxxxxx>
>> ---
>> This solution has previously been discussed on linux-usb [1] where
>> Alan Stern described the problem better:
> 
> Except that I forgot that a byte has _two_ hex digits!
> 

Oh, sorry, I overlooked the missing zeros for the parts where 0x was
used. IMHO the example is still clear.

> Regardless...
> 
> Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
> 

Thanks for reviewing!

Best regards,
  Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux