Re: [PATCH 2/2] usb/dummy_hcd: don't probe for udc if hcd failed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 14 Apr 2011, Sebastian Andrzej Siewior wrote:

> * Alan Stern | 2011-04-14 11:40:19 [-0400]:
> 
> >I would prefer to see this fixed by testing the_controller in init(), 
> >after the call to platform_device_add(the_hcd_pdev).  That way the user 
> >will know that initialization failed, rather than finding that things 
> >silently don't work.
> 
> This isn't actually that silently:
> 
> | usbcore: registered new device driver usb
> | dummy_hcd dummy_hcd: USB Host+Gadget Emulator, driver 02 May 2005
> | dummy_hcd dummy_hcd: Dummy host controller
> | dummy_hcd dummy_hcd: new USB bus registered, assigned bus number 1

What was the cause of the failure here?

> | dummy_hcd dummy_hcd: USB bus 1 deregistered
> | dummy_hcd: probe of dummy_hcd failed with error -22

This shows up only in the kernel log.  It would be better to have the 
entire initialization of the dummy-hcd module fail.

> However I can move that check if you prefer :)

Yes.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux