On Wed, 13 Apr 2011, Kristen Carlson Accardi wrote: > On Fri, 8 Apr 2011 17:15:24 -0400 (EDT) > Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > > > On Fri, 8 Apr 2011, Kristen Carlson Accardi wrote: > > > > > > Perhaps the existing irq and threaded_irq can even be the _same_. > > > > After all, they need to do pretty much the same things. > > > > > > > > Alan Stern > > > > > > It worked for me to use the existing usb_hcd_irq as a threadfn, > > > however with the quickcheck handler the way it is written now, > > > you'd need to add the intr_enable to the end of usb_hcd_irq, > > > > Right, except that the interrupt-enable can't be added to usb_hcd_irq() > > since that routine is part of the generic "glue" layer. It would have > > to be added to the end of ehci_irq(). > > > > > and > > > since it never masks the interrupts in the first place I'm not > > > sure if that would cause any side effects. > > > > One would need to carefully keep track of which interrupts are supposed > > to be enabled at any given time. That shouldn't be hard to do in > > ehci-hcd, but familiarity with the driver will help a lot -- I'm > > probably better qualified than you in this regard. > > So are you going to send an updated patch? Sorry, I have been busy with other things. I will post a patch to re-enable interrupts at the end of ehci_irq() soon. You can then go ahead and take care of the rest of the threaded-interrupt stuff. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
