Re: [PATCH 2/2] usb/usbtest: fix test10 on superpseed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 14, 2011 at 03:49:29PM +0200, Sebastian Andrzej Siewior wrote:
> Could someone check if this okay?
> 
> dummy_hcd + g_zero:
> 
> |./testusb -a -s 1024 -v 1024 -t 10
> | usbtest 2-1:3.0: subtest 14 error, status 0
> lots of those.
> 
> with patch:
>   ./testusb -a -t 10
> |unknown speed   /proc/bus/usb/001/002
> | dummy_udc dummy_udc: disabled ep-a
> | dummy_udc dummy_udc: disabled ep-b
> | dummy_udc dummy_udc: enabled ep-a (ep1in-bulk) maxpacket 1024
> | dummy_udc dummy_udc: enabled ep-b (ep2out-bulk) maxpacket 1024
> | zero gadget: source/sink enabled
> | usbtest 1-1:3.0: TEST 10:  queue 32 control calls, 1000 times
> | dummy_hcd dummy_hcd: timer fired with no URBs pending?
> |/proc/bus/usb/001/002 test 10,    0.022370 secs
> 
> Is this a fix or just duct tape? It seems correct since the descriptor
> is 18 bytes in size and we only read 9 bytes...

I think you need a bit more than that. In SuperSpeed, bMaxPacketSize0 is
an exponent to the base 2. So 9 means 2^9 == 512. Maybe you should
handle that correctly ?

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux