On Fri, Mar 25, 2011 at 01:03:12PM -0400, Alan Stern wrote: > On Fri, 25 Mar 2011, Michal Nazarewicz wrote: > > > The usb_create_sysfs_intf_files() function always returned zero even > > if it failed to create sysfs fails. Since this is a desired behaviour > > there is no need to return return code at all. This commit changes > > function's return type (form int) to void. > > > > Signed-off-by: Michal Nazarewicz <mina86@xxxxxxxxxx> > > Cc: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx> > > --- > > drivers/usb/core/sysfs.c | 13 +++++-------- > > drivers/usb/core/usb.c | 3 +-- > > drivers/usb/core/usb.h | 2 +- > > 3 files changed, 7 insertions(+), 11 deletions(-) > > > > On Fri, 25 Mar 2011 16:33:12 +0100, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > > > My style preference is to put the empty statement before the comment. > > > It's unusual to have a comment appearing before a statement on the same > > > line. For example: > > > ; /* We don't care if the function fails */ > > > > Changed. And I agree, it looks better now. :) > > Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> I can't find this version of the patch in my email archive anywhere. Michal, can you resend it so I can apply it? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
