RE: [PATCH 3/5] xHCI: Set link state support

["Xu, Andiry" <Andiry.Xu@xxxxxxx>]

> -----Original Message-----
> From: Sarah Sharp [mailto:sarah.a.sharp@xxxxxxxxxxxxxxx]
> Sent: Tuesday, April 12, 2011 12:30 AM
> To: Xu, Andiry
> Cc: linux-usb@xxxxxxxxxxxxxxx; gregkh@xxxxxxx
> Subject: Re: [PATCH 3/5] xHCI: Set link state support
> 
> Hi Andiry,
> 
> When apply this patch, I see the following checkpatch.pl warning
> message:
> 
> Your patch has no obvious style problems and is ready for submission.
> Applying: xHCI: Set link state support
> WARNING: msleep < 20ms can sleep for up to 20ms; see
> Documentation/timers/timers-howto.txt
> +			msleep(10); 
> total: 0 errors, 1 warnings, 62 lines checked
> 
> That seems to be referring to this code:
> 
> On Fri, Mar 25, 2011 at 05:11:54PM +0800, Andiry Xu wrote:
> > +			temp = xhci_port_state_to_neutral(temp);
> > +			temp &= ~PORT_PLS_MASK;
> > +			temp |= PORT_LINK_STROBE | link_state;
> > +			xhci_writel(xhci, temp, port_array[wIndex]);
> > +
> > +			spin_unlock_irqrestore(&xhci->lock, flags);
> > +			msleep(10); /* wait device to enter */
> > +			spin_lock_irqsave(&xhci->lock, flags);
> 
> I think it's fine to wait longer than 10ms here, is that correct?
> 

xHCI spec 4.15.1 specifies it takes as long as 10ms to make a link enter
U3 state. But I think 20ms is OK, I'll correct it in the next patchset.

Thanks,
Andiry
ÿô.nlj·Ÿ®‰­†+%ŠË±é¥Šwÿº{.nlj·¥Š{±þë)íèjg¬±¨¶‰šŽŠÝjÿ¾«þG«é¸¢·¦j:+v‰¨Šwèm¶Ÿÿþø®w¥þŠà£¢·hšâÿ†Ù