Hi Andiry, When apply this patch, I see the following checkpatch.pl warning message: Your patch has no obvious style problems and is ready for submission. Applying: xHCI: Set link state support WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt + msleep(10); total: 0 errors, 1 warnings, 62 lines checked That seems to be referring to this code: On Fri, Mar 25, 2011 at 05:11:54PM +0800, Andiry Xu wrote: > + temp = xhci_port_state_to_neutral(temp); > + temp &= ~PORT_PLS_MASK; > + temp |= PORT_LINK_STROBE | link_state; > + xhci_writel(xhci, temp, port_array[wIndex]); > + > + spin_unlock_irqrestore(&xhci->lock, flags); > + msleep(10); /* wait device to enter */ > + spin_lock_irqsave(&xhci->lock, flags); I think it's fine to wait longer than 10ms here, is that correct? Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
